solve issue #1780 (built-in matdefs/shaders lack core-profile support) #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I verified that this PR solves issue 1780 on macOS Monterey. |
|
Optimistically interpreting the thumbs-up emojis as positive code reviews, I plan to self-integrate this PR in about 24 hours ... unless there's something to discuss. |
stephengold
added a commit
that referenced
this pull request
Mar 18, 2022
#1781) * jme3-terrain: add GLSLCompat.glsllib to 4 jme3-terrain frag shaders * jme3-terrain: add GLSLCompat.glsllib to 4 jme3-terrain vertex shaders * jme3-terrain: add GLSL150 to 3 jme3-terrain material definitions * jme3-vr: add GLSLCompat.glsllib to 5 shaders * jme3-niftygui: add GLSLCompat.glsllib to 6 shaders * jme3-niftygui: add GLSL150 to 3 material definitions
stephengold
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "GLSL150" to matdefs and
#import "Common/ShaderLib/GLSLCompat.glsllib"to shaders. Not certain I got them all.