Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-organize jme3-jbullet sourcecode #1817

Merged
merged 1 commit into from
May 15, 2022
Merged

Conversation

stephengold
Copy link
Member

In the wake of PR #1474, the source code for the jme3-jbullet library remains split between 2 directories: jme3-jbullet/src/main/java/com/jme3/bullet and jme3-bullet/src/common/java/com/jme3/bullet

The jme3-jbullet library shows no signs of dying, and the meanwhile the split has proven confusing and inconvenient. I therefore propose to merge the "common" source files into the jme3-jbullet directory.

@stephengold stephengold added this to the Future Release milestone May 10, 2022
@MeFisto94
Copy link
Member

On a similar note, we may want to integrate jbullet directly, as a submodule? into the repository? or at least in some kind of pipeline, since we're going to have to fix jbullet bugs as well and normen found our version

@stephengold
Copy link
Member Author

we may want to integrate jbullet directly

The difficulty is that I haven't managed to build jbullet without using Ant. I know there are ways to integrate Ant tasks into Gradle builds, but I haven't made them work for this particular case. In order to publish a jbullet library, I build the source jar, javadoc jar, pom, and module using Gradle, but build the class jar using Ant.

@stephengold
Copy link
Member Author

Barring further discussion, I plan to self-integrate this PR in about 24 hours.

@stephengold stephengold merged commit 0e9705e into master May 15, 2022
@stephengold stephengold deleted the sgold/physics-reorg branch May 15, 2022 16:56
@Ali-RS Ali-RS modified the milestones: Future Release, v3.6.0 Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants