Clean up the display modes parsing #1844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heh, I had this sitting locally for some time. Might as well turn it in.
Basically it is cleanup. Changed loops to modern for each loops. Avoids some unnecessary string concatenations and other unnecessary operations especially when trying to get the depths. And changes the toArray calls to faster one (https://shipilev.net/blog/2016/arrays-wisdom-ancients/).
In all the data handled is so minuscule that I doubt there is anything noticeable in performance. But code might be a bit more readable with less nesting and using DisplayMode.BIT_DEPTH_MULTI instead of magically discarding "-1" from the depths...