Fix #1871 (vertex colors not loaded in gltf models) #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. |
|
Thanks @tonihele |
Ali-RS
reviewed
Nov 28, 2022
jme3-plugins/src/gltf/java/com/jme3/scene/plugins/gltf/GltfUtils.java
Outdated
Show resolved
Hide resolved
Ali-RS
changed the title
|
I'll merge this in roughly 8 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1871
With @Ali-RS doing the heavy lifting, this was very trivial to figure out. We just read the wrong amount of bytes when reading as float from arrays of short. Tested with the Duck and the Girl supplied in the issue. Both still work. Only the Girl has these normalized ushort float buffers though.