Catch and log all uncaught exceptions propagated from simpleUpdate(). #1952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently encountered an issue where exceptions were propagating out of my code and silently being swallowed without the usual "uncaught exception" window being shown or any logging. Since jME already tries to handle this case, I was surprised after a couple of hours of debugging to find that the origin was an exception coming from within
simpleUpdate()
(in my case it happened in a subtle and rather difficult to debug scenario).The solution I added in my codebase was wrapping the body of
simpleUpdate()
in a try-catch block and logging the stack trace. SinceSimpleApplication
aims to be a consistent and easy to use one-stop-shop for app-level concerns, it would be nice if it handled this situation as well.I'm not entirely convinced that this is the best way to do this (especially given jME's existing uncaught exception handling), but it seems a reasonable starting point for further discussion - feedback is welcomed.