Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't code the Gradle version in build.gradle #2213

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

stephengold
Copy link
Member

As discussed at PR #2207, the Engine currently codes the Gradle version in 2 places (build.gradle and gradle/wrapper/gradle-wrapper.properties).

As a result:

  • The Engine's procedure for updating Gradle differs from that described in Gradle release notes, requiring an extra step.
  • It's possible for the coded versions to get out of synch with one another, causing confusion about which version is used to build the Engine.

This PR deletes the "wrapper" block from build.gradle .

As a result:

  • The Engine's Gradle version is coded in a single, central place.
  • The upgrade procedure documented in Gradle release notes will suffice, but a simple "gradlew update" will not.

@stephengold stephengold added the buildscript An issue with the buildscript label Mar 5, 2024
@scenemax3d scenemax3d added this to the v3.7.0 milestone Mar 8, 2024
@scenemax3d scenemax3d merged commit 88d94b7 into master Mar 8, 2024
14 checks passed
@stephengold stephengold deleted the sgold/gradle-wrapper branch March 9, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buildscript An issue with the buildscript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants