Skip to content

Added a (hacky) fix for a Java Swing/AWT + GLFW interaction issue… #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
empirephoenix merged 3 commits into from
Dec 14, 2018
Merged

Added a (hacky) fix for a Java Swing/AWT + GLFW interaction issue… #968

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33412aa
Added a (hacky) fix for a Java Swing/AWT + GLFW interaction issue…
Ali-RS Dec 9, 2018
a6b992f
Added a proper comment
Ali-RS Dec 10, 2018
6fa0586
Added an extra call to System.gc() as recommendation from lwjgl’s @Spasi
Ali-RS Dec 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions jme3-desktop/src/main/java/com/jme3/app/SettingsDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,12 @@ public void actionPerformed(ActionEvent e) {
if (verifyAndSaveCurrentSelection()) {
setUserSelection(APPROVE_SELECTION);
dispose();

// System.gc() should be called to prevent "X Error of failed request: RenderBadPicture (invalid Picture parameter)"
// on Linux when using AWT/Swing + GLFW.
// For more info see: https://github.com/LWJGL/lwjgl3/issues/149, https://hub.jmonkeyengine.org/t/experimenting-lwjgl3/37275
System.gc();
System.gc();
}
}
});
Expand Down