New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] fixing enable lazy load #194

Merged

jaanauati merged 1 commit into jaanauati:master from marcosvlehmkuhl:fix-lazy-loading

Jun 25, 2020

Contributor

marcosvlehmkuhl commented Jun 24, 2020

#193
So I believe that there were two problems:

googletag.PubAdsService.enableLazyLoad should receive an object but it was given an array.
Calling enableLazyLoad with the .call method will change the this reference inside the function enableLazyLoad what may be causing the bug.


          [fix] fix enableLazyload

005a81c

Owner

jaanauati commented Jun 24, 2020

@marcosvlehmkuhl makes sense, i'll try to get this tested and merged btw today - tomorrow morning.
Thank you!

jaanauati merged commit adf62ed into jaanauati:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet