Fix a race condition when refresh is called closely to defineSlots #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This bug was a doozy to find, but I think this is the code required to fix it.
If there was a pending (un-resolved) load promise with defineSlot commands sitting waiting to be added to the gpt command queue and refresh was called, refresh would run too soon, calling refresh before the slots were defined. By linking the refresh to the loadPromise, we guarantee that slots that are sitting in the load queue are defined before refresh is called.
This is my first contribution to this library and there's not a formal contributing instructions so please let me know if there's anything else you need from me.