Token from string #12
Conversation
src/lexer/lex.c
Outdated
| } | ||
|
|
||
| // Does it start with a negative sign | ||
| if (contents[0] != '\0') { |
There was a problem hiding this comment.
The logic here is redundant methinks (you only need the inner if), also why would we return an identifier? Wouldn't this return TT_IDENTIFIER for the string -= which is an operator?
There was a problem hiding this comment.
Yup, removed outer if
There was a problem hiding this comment.
Will the lexer lex -= as a single token or will it do - and = separately?
src/lexer/lex.c
Outdated
| } | ||
|
|
||
| // Is it from "0123456789"? | ||
| if (c > 57 || c < 48 && c != 'u') { |
There was a problem hiding this comment.
I might use the literal characters here instead of 57 and 48 so it's clearer
src/lexer/lex.c
Outdated
| } | ||
|
|
||
| // Does it start with a negative sign | ||
| if (contents[0] == '-') { |
There was a problem hiding this comment.
As far as I know, the only tokens that can start with negative signs are -, -- and -=.
There was a problem hiding this comment.
Am I forgetting something? Because I don't think those are allowed in identifiers in the first place
src/lexer/lex.c
Outdated
| } | ||
|
|
||
| // Count negative signs | ||
| if (c == '-') { |
There was a problem hiding this comment.
In C, the expression -2 is literally counted as - and then 2, as two separate tokens. In the exact same way as you can say int positive = 2, negative = -positive; or whatever.
closes #4