add token tracking #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would close issue #8 |
|
last commit would close #32 |
src/lexer/token.h
Outdated
| char contents[TOKEN_LENGTH]; // The actual contents of the token. | ||
| unsigned length; // How long the token is. | ||
| char source_file[TOKEN_LENGTH]; // The source file the token was in. | ||
| long position_in_file; // Where in the file the token started, as an index. |
There was a problem hiding this comment.
Is there a way to get row/column info from this? If not, we should maybe switch to that so we can give helpful error messages.
There was a problem hiding this comment.
my plan was to have the error reporting find that. It is simpler (i think?) to just crawl to the relevant position and hold onto a few rows of buffer. plus, errors are only usually called a few times, but this is tracked for every token
There was a problem hiding this comment.
ok so line and column information is now being tracked instead
src/lexer/lex.c
Outdated
| } | ||
|
|
||
| int lexer_ungetchar(Lexer *l) { | ||
| // if called before getchar ever is this could cause problems |
There was a problem hiding this comment.
Maybe add an normal assert to prevent this and crash
There was a problem hiding this comment.
assert(l->position >= 0);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds positional data to the token struct that contains where that token starts
modified the lexer struct and made getc and ungetc wrappers to keep track of location
made the lexing function store tokens with positional data