Feature: Thresholds #1109
Feature: Thresholds #1109
Conversation
|
Ready for peer review. |
|
Hmm it is somehow similar to my changes |
|
I believe yours is better, in any case i think 1000 is too much for Pokémon as i heard thats the value in ca 24h you get Banned for. Ah and do you know how i can "rewind" the last commits from my pull request here in github? |
|
Ah and one more thing, could you also make the waittime which is 12h choosable from settings please? |
|
@AlexBoulyga My apologies, I haven't checked pull requests recently. I had thought of how it would be beneficial to continue to walk around and hatch eggs, but maybe stopping entirely would be more human-like which could lead to less flagging. |
|
@AlexBoulyga I don't know how to rewind commits, unfortunately. However, I will go ahead and change the values and add a setting for the delay time in the morning. |
| @@ -131,7 +131,11 @@ class SettingsParser(val properties: Properties) { | |||
|
|
|||
| waitTimeMin = getPropertyIfSet("Minimal time to wait", "wait_time_min", defaults.waitTimeMin, String::toInt), | |||
|
|
|||
| waitTimeMax = getPropertyIfSet("Maximal time to wait", "wait_time_max", defaults.waitTimeMax, String::toInt) | |||
| waitTimeMax = getPropertyIfSet("Maximal time to wait", "wait_time_max", defaults.waitTimeMax, String::toInt), | |||
There was a problem hiding this comment.
*Maximum
EDIT: Oh lol I see you didn't add this.
There was a problem hiding this comment.
It was me, ill change it in my commit :)
FIXED
|
not sure here is the best place to do this, I'm new to GitHub, sorry for my noobishness Would it complicate things a lot to change it so that it keeps the values for Pokemons caught so far and Pokestops visited so far somewhere locally, so even if let's say the bot crashes or is stopped, if restarted it will continue from the previous values. |
This pull request adds thresholds for a maximum amount of looted Pokestops and caught Pokemon. This will prevent the bot from continuously catching Pokemon and looting Pokestops, which normally leads to your account being flagged.
Changes made: