Skip to content
This repository has been archived by the owner on Jul 22, 2019. It is now read-only.

Updated explanation in several files #1152

Merged
merged 5 commits into from
Aug 18, 2016
Merged

Updated explanation in several files #1152

merged 5 commits into from
Aug 18, 2016

Conversation

Sieberkev
Copy link
Collaborator

@Sieberkev Sieberkev commented Aug 17, 2016

Updated/added/fixed/... some explanation in several files.

Any more stuff that's missing?

* Secure your API with the `rest_api_password` setting. This password is shared across all bots. If the setting isn't set, it will be generated and saved in the config file.
* Request an access token with a `POST` to `/api/bot/{name}/auth`, the request body must be `rest_api_password`. This token must be placed in the `X-PGB-ACCESS-TOKEN` header for further use of the API.
* Bot end-point :
* Secure your API by putting a secure and random password in the `rest_api_password` setting in your config.properties file. This password is shared across all bots. If the configuration key is not set, it will be generated and saved in the config file.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some commits before everything transitioned to the json format afaik

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paging @Peyphour -> how does this work with the JSON files? Also I did notice if it was empty, it didn't autofill in the configuration file :o

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to test it right now

@Sieberkev Sieberkev merged commit 3cb2706 into jabbink:develop Aug 18, 2016
@Sieberkev Sieberkev deleted the minor_readme_updates branch August 18, 2016 07:44
kalijason pushed a commit to kalijason/PokemonGoBot that referenced this pull request Aug 19, 2016
* Updated some of the readme files (API/FAQ/USAGE and ISSUE TEMPLATE)

* Additional information

* Fixed some words with feedback from jabbink

* Lowercase "ptc", to be sure ^-^

* Some more clarification
Sieberkev pushed a commit that referenced this pull request Aug 19, 2016
* Use correct altitude

* Rebase (#1)

* Updated explanation in several files (#1152)

* Updated some of the readme files (API/FAQ/USAGE and ISSUE TEMPLATE)

* Additional information

* Fixed some words with feedback from jabbink

* Lowercase "ptc", to be sure ^-^

* Some more clarification

* Fix #1147 (#1157)

* Ensure template correctness (#1154)

* fixed typo in template file

* wrote tests for json-template

* fixed json-template with help from the new TestSettings

* Separated json credential testing from properties testing

* Use correct altitude(and cache it)

* Rebase (#2)

* Updated explanation in several files (#1152)

* Updated some of the readme files (API/FAQ/USAGE and ISSUE TEMPLATE)

* Additional information

* Fixed some words with feedback from jabbink

* Lowercase "ptc", to be sure ^-^

* Some more clarification

* Fix #1147 (#1157)

* Ensure template correctness (#1154)

* fixed typo in template file

* wrote tests for json-template

* fixed json-template with help from the new TestSettings

* Separated json credential testing from properties testing

* Cleaner string concatenation

* Use Google API first(without API key), when it hits the rate limit, use mapzen

* More try block coverage

* Added logging if requests fail, removed unused import

* More detailed log message
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants