This repository has been archived by the owner on Jul 22, 2019. It is now read-only.
[REST API] Added HTTP status codes for bad auth/requests #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated API.md file
|
Pinging @JoeyyT to see if this has any negative consequences on your GUI (it shouldn't, with the codes it should be even be better to catch errors any errors (when the statuscode is not 200)). |
| - POST `/api/bot/{name}/pokemon/{id}/evolve` => Evolve pokemon | ||
| - POST `/api/bot/{name}/pokemon/{id}/powerup` => Power-up pokemon | ||
| - POST `/api/bot/{name}/pokemon/{id}/evolve` => Evolve pokemon (HTTP status code 400 (Bad Request) when not enough candy) | ||
| - POST `/api/bot/{name}/pokemon/{id}/powerup` => Power-up pokemon (HTTP status code 400 (Bad Request) when not enough candy) |
There was a problem hiding this comment.
I've added a stardust check (that was missing).
|
nothing will change for TTL55, rather will be better, cause it's already in the js to show a failed message if not a 200 response received. |
…e sentences * Added missing stardust check on powerup
| if (count == 0) { | ||
| httpResponse.status = HttpServletResponse.SC_BAD_REQUEST | ||
| return "Not enough incense" | ||
| } else { | ||
| itemBag.useIncense() |
There was a problem hiding this comment.
log if usage successfull? maybe also for luckyegg and location change request
* Cleanup some one-use vars
Sieberkev
added a commit
that referenced
this pull request
Sep 6, 2016
* fix build * Updated AUTHORS.md (#1262) * API.md - Slashes missing in documentation (#1263) * Add checkstyle to Gradle build (#1246) * Enabled Checkstyle in Gradle * Added checkstyle to build.gradle (only check "src/main/kotlin" and not the libraries) * Fixed several checkstyle errors (File contains tab characters, Space needed before opening parenthesis, Line has trailing spaces) so the current checkstyle.xml builds without errors * * Added check to avoid "){" * [REST API] Added HTTP status codes for bad auth/requests (#1264) * * Added status codes on bad requests/auth * Updated API.md file * * Replaced string concatenations with proper ${}'s and cleaned up some sentences * Added missing stardust check on powerup * * Update API.md with stardust check * * Added more console logging * Cleanup some one-use vars * Improved config loading/saving (#1270) * Remove unused ProgramController * Renamed util.io.export*Writer classes/files * Moved BotService save/load to new class/file util.io.SettingsJSONWriter * Fix REST API pokedex indexes (#1275) * Fix missing pokemons (missingno #0, mew #151) in REST API pokedex call
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue: #1139 (comment)
Changes made:
the server cannot or will not process the request due to something that is perceived to be a client error)/ auth 401