Modify formatDate to return null on invalid Date object

jac-uk · Jul 29, 2020 · 6aa2351 · 6aa2351
1 parent da3cefc
commit 6aa2351
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/filters.js b/src/filters.js
@@ -3,6 +3,12 @@ import { APPLICATION_STATUS } from '@/helpers/constants';
 const formatDate = (value, type) => {
   if (value) {
     const objDate = new Date(Date.parse(value));
+
+    // If not a valid date
+    if (!(objDate instanceof Date)){
+      return null;
+    }
+
     switch (type) {
       case 'month':
         return `${objDate.toLocaleString('en-GB', { month: 'long' })} ${objDate.getUTCFullYear()}`;

diff --git a/src/views/Exercises/Applications/Application.vue b/src/views/Exercises/Applications/Application.vue
@@ -76,7 +76,7 @@
               <h2 
                 class="govuk-heading-m govuk-!-margin-bottom-0"
               >
-                {{ application.createdAt | showAlternative("Unknown") | formatDate }}
+                {{ application.createdAt | formatDate | showAlternative("Unknown")}}
               </h2>
             </div>
           </div>
@@ -88,7 +88,7 @@
                 v-if="isApplied"
                 class="govuk-heading-m govuk-!-margin-bottom-0"
               >
-                {{ application.createdAt | showAlternative("Unknown") | formatDate }}
+                {{ application.appliedAt | formatDate | showAlternative("Unknown") }}
               </h2>
               <h2
                 v-else