tidy up

jac-uk · Oct 31, 2024 · d98a93b · d98a93b
1 parent 20d6400
commit d98a93b
Showing 1 changed file with 34 additions and 31 deletions.
diff --git a/src/views/Exercise/Reports/Diversity.vue b/src/views/Exercise/Reports/Diversity.vue
@@ -128,7 +128,7 @@
                 Applications
               </th>
               <th
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 scope="col"
                 class="govuk-table__header govuk-table__header--numeric"
               >
@@ -148,7 +148,7 @@
                 <Stat :stat="diversity[activeTab].gender.male" />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].gender.male) }}
@@ -165,7 +165,7 @@
                 <Stat :stat="diversity[activeTab].gender.female" />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].gender.female) }}
@@ -183,7 +183,7 @@
                 />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].gender.declaration) }}
@@ -211,7 +211,7 @@
                 Applications
               </th>
               <th
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 scope="col"
                 class="govuk-table__header govuk-table__header--numeric"
               >
@@ -231,7 +231,7 @@
                 <Stat :stat="diversity[activeTab].ethnicity.bame" />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].ethnicity.bame) }}
@@ -248,7 +248,7 @@
                 <Stat :stat="diversity[activeTab].ethnicity.white" />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].ethnicity.white) }}
@@ -266,7 +266,7 @@
                 />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].ethnicity.declaration) }}
@@ -294,7 +294,7 @@
                 Applications
               </th>
               <th
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 scope="col"
                 class="govuk-table__header govuk-table__header--numeric"
               >
@@ -311,7 +311,7 @@
                 <Stat :stat="diversity[activeTab].disability.yes" />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].disability.yes) }}
@@ -325,7 +325,7 @@
                 <Stat :stat="diversity[activeTab].disability.no" />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].disability.no) }}
@@ -343,7 +343,7 @@
                 />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].disability.total) }}
@@ -371,7 +371,7 @@
                 Applications
               </th>
               <th
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 scope="col"
                 class="govuk-table__header govuk-table__header--numeric"
               >
@@ -391,7 +391,7 @@
                 <Stat :stat="diversity[activeTab].professionalBackground.barrister" />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].professionalBackground.barrister) }}
@@ -405,7 +405,7 @@
                 <Stat :stat="diversity[activeTab].professionalBackground.cilex" />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].professionalBackground.cilex) }}
@@ -419,7 +419,7 @@
                 <Stat :stat="diversity[activeTab].professionalBackground.solicitor" />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].professionalBackground.solicitor) }}
@@ -434,7 +434,7 @@
                 <Stat :stat="diversity[activeTab].professionalBackground.other" />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].professionalBackground.other) }}
@@ -453,7 +453,7 @@
                 />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].professionalBackground.declaration) }}
@@ -484,7 +484,7 @@
                 Applications
               </th>
               <th
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 scope="col"
                 class="govuk-table__header govuk-table__header--numeric"
               >
@@ -501,7 +501,7 @@
                 <Stat :stat="diversity[activeTab].attendedUKStateSchool.attendedUKStateSchool" />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].attendedUKStateSchool.attendedUKStateSchool) }}
@@ -519,7 +519,7 @@
                 />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].attendedUKStateSchool.declaration) }}
@@ -548,7 +548,7 @@
                   Applications
                 </th>
                 <th
-                  v-if="activeTab !== 'applied'"
+                  v-if="isNotApplied"
                   scope="col"
                   class="govuk-table__header govuk-table__header--numeric"
                 >
@@ -565,7 +565,7 @@
                   <Stat :stat="diversity[activeTab].firstGenerationUniversity.firstGenerationUniversity" />
                 </td>
                 <td
-                  v-if="activeTab !== 'applied'"
+                  v-if="isNotApplied"
                   class="govuk-table__cell govuk-table__cell--numeric"
                 >
                   {{ showChange(diversity[activeTab].firstGenerationUniversity.firstGenerationUniversity) }}
@@ -583,7 +583,7 @@
                   />
                 </td>
                 <td
-                  v-if="activeTab !== 'applied'"
+                  v-if="isNotApplied"
                   class="govuk-table__cell govuk-table__cell--numeric"
                 >
                   {{ showChange(diversity[activeTab].firstGenerationUniversity.declaration) }}
@@ -613,7 +613,7 @@
                   Applications
                 </th>
                 <th
-                  v-if="activeTab !== 'applied'"
+                  v-if="isNotApplied"
                   scope="col"
                   class="govuk-table__header govuk-table__header--numeric"
                 >
@@ -630,7 +630,7 @@
                   <Stat :stat="diversity[activeTab].parentsNotAttendedUniversity.parentsNotAttendedUniversity" />
                 </td>
                 <td
-                  v-if="activeTab !== 'applied'"
+                  v-if="isNotApplied"
                   class="govuk-table__cell govuk-table__cell--numeric"
                 >
                   {{ showChange(diversity[activeTab].parentsNotAttendedUniversity.parentsNotAttendedUniversity) }}
@@ -648,7 +648,7 @@
                   />
                 </td>
                 <td
-                  v-if="activeTab !== 'applied'"
+                  v-if="isNotApplied"
                   class="govuk-table__cell govuk-table__cell--numeric"
                 >
                   {{ showChange(diversity[activeTab].parentsNotAttendedUniversity.declaration) }}
@@ -677,7 +677,7 @@
                 Applications
               </th>
               <th
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 scope="col"
                 class="govuk-table__header govuk-table__header--numeric"
               >
@@ -700,7 +700,7 @@
                 <Stat :stat="diversity[activeTab].emp.applied" />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].emp.applied) }}
@@ -717,7 +717,7 @@
                 <Stat :stat="diversity[activeTab].emp.ethnicity" />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].emp.ethnicity) }}
@@ -734,7 +734,7 @@
                 <Stat :stat="diversity[activeTab].emp.gender" />
               </td>
               <td
-                v-if="activeTab !== 'applied'"
+                v-if="isNotApplied"
                 class="govuk-table__cell govuk-table__cell--numeric"
               >
                 {{ showChange(diversity[activeTab].emp.gender) }}
@@ -870,6 +870,9 @@ export default {
       }
       return '';
     },
+    isNotApplied() {
+      return this.activeTab !== 'applied';
+    },
   },
   watch: {
     tabs: {