Bugfix: Application personal details should update candidate

jac-uk · Feb 20, 2023 · db07af8 · db07af8
1 parent 3ccadca
commit db07af8
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/views/Exercise/Applications/Application.vue b/src/views/Exercise/Applications/Application.vue
@@ -478,7 +478,6 @@ export default {
   },
   created() {
     this.pageLoad();
-    this.$root.$on('changeUserDetails', (obj) => this.changeUserDetails(obj));
   },
   destroyed() {
     this.$store.dispatch('application/unbind');
@@ -580,13 +579,13 @@ export default {
       }
       return objChanged;
     },
-    changeUserDetails(objChanged) {
+    changePersonalDetails(objChanged) {
       if (objChanged.firstName || objChanged.lastName) {
         objChanged = this.makeFullName(objChanged);
       }
 
       const myPersonalDetails = { ...this.application.personalDetails, ...objChanged };
-      this.$store.dispatch('application/update', { data: { personalDetails: myPersonalDetails }, id: this.applicationId });
+      this.changeApplication({ personalDetails: myPersonalDetails });
       this.$store.dispatch('candidates/savePersonalDetails', { data: objChanged, id: this.application.userId });
 
       logEvent('info', 'Application updated (personal details)', {
@@ -604,9 +603,6 @@ export default {
     changeApplication(obj) {
       this.$store.dispatch('application/update', { data: obj, id: this.applicationId });
     },
-    changePersonalDetails(obj) {
-      this.changeApplication({ personalDetails: obj });
-    },
   },
 };
 </script>