Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports should be prepared server-side #1100

Closed
warrensearle opened this issue Dec 2, 2020 · 9 comments
Closed

Exports should be prepared server-side #1100

warrensearle opened this issue Dec 2, 2020 · 9 comments
Assignees

Comments

@warrensearle
Copy link
Member

Currently we have a number of 'Export to XLSX' buttons in admin and these are all downloading full data to the client and then transforming it into the desired XLSX format. This is clunky. Instead we should be doing this on the server-side and perhaps saving the data to Google Drive as a Google Sheet instead of allowing a direct download.

@KateMJAC
Copy link

Assigned to Halcyon in the March WO.

@HalcyonJAC
Copy link
Contributor

HalcyonJAC commented Mar 4, 2021

There appear to be a number of pages with Export XYZ buttons on them that use the existing client-side downloadXLSX() function, which need moving to a server-side implementation:

  • Exercises
  • Applications - Export Contacts
  • Reports - Diversity Report
  • Reports - Handover
  • Reports - Outreach
  • Reports - Reasonable Adjustments
  • Reports - Qualifying Test Report
  • Qualifying Tests - Responses

Please confim whether the above list is correct or not

@HalcyonJAC HalcyonJAC added the question Further information is requested label Mar 4, 2021
@warrensearle
Copy link
Member Author

warrensearle commented Mar 5, 2021

Hi @HalcyonJAC and @JeremykJAC the following pages are the ones to optimise (and I believe covers all of them):

  • Applications - Export Contacts
  • Reports - Handover
  • Reports - Reasonable Adjustments
  • Qualifying Tests - Responses

The following, mentioned above, are all ok as the data being converted to xlsx is already pre-generated or created server-side:

  • Exercises a cloud function does the heavy lifting here. NB this is also being worked on this month
  • Reports - Diversity Report report is pre-generated via a cloud function
  • Reports - Outreach report is pre-generated via a cloud function
  • Reports - Qualifying Test Report report is pre-generated via a cloud function

@warrensearle
Copy link
Member Author

For now I think let's keep them as xlsx downloads.
We can consider exporting to google drive in a future ticket.

@warrensearle warrensearle mentioned this issue Mar 5, 2021
3 tasks
@HalcyonJAC
Copy link
Contributor

Thanks @warrensearle !

@KateMJAC
Copy link

Please leave for my return on 22/03 for testing and approval for release.

@HalcyonJAC HalcyonJAC removed the question Further information is requested label Mar 22, 2021
@KateMJAC
Copy link

@HalcyonJAC @JeremykJAC I have tested this and found the following:

• Applications - Export Contacts: I was able to export the contacts. There was no refresh button, but i'm guessing that was because it doesn't fall under reports? as is the case with QT - Responses.

• Reports – Handover: Refresh button was there and I was able to download the report.

• Reports - Reasonable Adjustments: Refresh button was there and I was able to download, however the report listed two people within it, while the platform only listed one candidate as having reasonable adjustments (pictures below).

• Qualifying Tests – Responses: Was able to dowload the responses. There was no refresh button - as above for applications - Export Contacts.

1. RA platform list.png

2. RA download.png

@HalcyonJAC
Copy link
Contributor

Hi @KateMJAC

I have spent some time today trying to replicate the problem you found with the Reasonable Adjustments report, on my workstation but have not managed to. This is could be down to my lack of knowledge on the lifecycle of an exercise and system workflow. I would have called one of the developers for help but didn't want to take much of their time up.

In any case I have some changes to the exports so that the export button is no longer enabled unless there is actually data to export at least, to avoid other possible errors.

I will speak to one of the dev team tomorrow and see if they can help me replicate this problem locally so I can get to the bottom of it.

Darrel

@HalcyonJAC HalcyonJAC linked a pull request Mar 29, 2021 that will close this issue
@KateMJAC
Copy link

Positive result during testing by Tester User Group. I also tested with a positive result. This can move to reviewed,

warrensearle added a commit that referenced this issue Apr 12, 2021
 #1201 Include version number in UI and Sentry
 #1033 FIX TypeError: Cannot read property 'shareData' of undefined
 #1212 S9(1) type exercise functionality (ex 35)
 #1100 Exports should be prepared server-side
 #1081 Report improvements
 #1224 Fix: Tabs no longer function on application view
 #1237 Fix: Configure npm to use github packages for JAC Kit
 #1242 Fix: All candidates in stages tab moved to withdrawn Exercise 014 and 010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants