Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1093 Update CircleCI config to access Github Packages registry #1095

Merged
merged 4 commits into from
Nov 27, 2020
Merged

#1093 Update CircleCI config to access Github Packages registry #1095

merged 4 commits into from
Nov 27, 2020

Conversation

warrensearle
Copy link
Member

@warrensearle warrensearle commented Nov 27, 2020 •
edited
Loading

This is a rather simple fix, in the end.

  1. Create a Personal Access Token (PAT) in Github solely with 'read:packages' access

Screenshot 2020-11-27 at 12 33 31

  1. Add a new environment variable in CircleCI called GITHUB_PACKAGES_TOKEN and copy the PAT into it
  2. Update CircleCI config.yml to append the token to our .npmrc config file at run-time
  3. Continue with install, test, build as before

Note: unit tests need fixing but that's outside the scope of this ticket :)

@warrensearle warrensearle added this to the 20NOVB milestone Nov 27, 2020
tomlovesgithub
tomlovesgithub approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@tomlovesgithub tomlovesgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, nice that the problem is what we thought

@warrensearle warrensearle merged commit a15f1b4 into feature/1063-extension Nov 27, 2020
@warrensearle warrensearle deleted the feature/1093-ci-config branch November 27, 2020 15:24
lloback pushed a commit that referenced this pull request Nov 27, 2020
@warrensearle @lloback
#1093 Update CircleCI config to access Github Packages registry (#1095)
e3233f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlovesgithub tomlovesgithub tomlovesgithub approved these changes

@mbrookeswebdev mbrookeswebdev mbrookeswebdev approved these changes

@lloback lloback lloback approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20NOVB
Development

Successfully merging this pull request may close these issues.
4 participants
@warrensearle @lloback @mbrookeswebdev @tomlovesgithub