#1198 Fixed issue of a QT results download unable to start if candidates skip questions and submit with no answers. #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes skip questions and submit with no answers.
mbrookeswebdev
requested review from
warrensearle,
tomlovesgithub and
HalcyonJAC
warrensearle
approved these changes
Mar 4, 2021
Comment on lines
+164
to
+166
| if ((responseSelection.mostAppropriate !== undefined && responseSelection.mostAppropriate !== null) | ||
| && (responseSelection.leastAppropriate !== undefined && responseSelection.leastAppropriate !== null)) | ||
| { |
There was a problem hiding this comment.
You could perhaps simplify this by using == null to cover both the null and undefined scenarios. So
if (
responseSelection.mostAppropriate != null &&
responseSelection.leastAppropriate != null
)
There was a problem hiding this comment.
I try not to use == anymore and go for ===, to avoid any conversions taking place and to make clear what we need to check.
There was a problem hiding this comment.
Yes it's best to use === but there's a camp, which includes me, that thinks it's ok to use == null and != null.
e.g. see here: http://adripofjavascript.com/blog/drips/equals-equals-null-in-javascript.html
It's fine either way
| @@ -202,7 +204,7 @@ export default { | |||
| } | |||
| if (responses) { | |||
| responses.forEach((response) => { | |||
| row.push(response.text === null ? 'Question skipped' : response.text); | |||
| row.push(response.text === undefined || response.text === null ? 'Question skipped' : response.text); | |||
There was a problem hiding this comment.
Perhaps use != null to check for null and undefined
| @@ -219,7 +221,7 @@ export default { | |||
| } | |||
| if (response) { | |||
| const responseSelection = response.selection; | |||
| if (responseSelection !== undefined) { | |||
| if (responseSelection !== undefined && responseSelection !== null) { | |||
There was a problem hiding this comment.
Perhaps use != null to check for null and undefined
mbrookeswebdev
deleted the
feature/1198-unable-to-download-critical-analysis-test-result
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing instructions are in the ticket description along with test scripts for reference.