Feature/equal merit tie breakers

[HalcyonJAC]

---

PREVIEW:DEVELOP

[github-actions]

Visit the preview URL for this PR (updated for commit 851ac37):

https://jac-admin-develop--pr1261-feature-equal-merit-8xft220h.web.app

_{(expires Sat, 28 Aug 2021 13:11:28 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

[joy-ade]

@halcyon can you regenerate the PR pls.

[HalcyonJAC]

Merge conflicts resolved and router bugs fixed. PR url regenerated.

It would be good to get a re-review of this and sent for testing again.

[mbrookeswebdev]

@HalcyonJAC when I click on 'Equal merit tie-breakers' link it takes me back to Exercises list -

[HalcyonJAC]

Thanks @mbrookeswebdev it looks like the routes were merged into the wrong place after staged applications maybe? I've edited and it appears to work now. Please could you try again?

[joy-ade]

@HalcyonJAC @JeremykJAC Thanks for resolving the merged conflict. However while l was creating an Equal merit tie breakers test there was an issues inputting date and time in the field. I know Kate has flagged this issue before. The scenario here should be the same as the qualifying time. I should be able to set the date and time without making changes to the date in timeline.

[joy-ade]

Approved by UTG

[warrensearle]

Code changes look good to me 👍

[JeremykJAC]

Hi @joy-ade

The reason this is happening is because there is an EMT second stage date set for the 22/07/21 and therefore the system requires the first EMT to be completed.

This was included on the development plan:

• 'When creating a EM tie-breaker the start and end dates for the test should default to the Equal Merit Second Phase start and end dates for the exercise'.

Would you like us to ignore the second stage and allow the end date to be set afterwards?

[joy-ade]

@KateMJAC FYI

JeremykJAC
commented 20 minutes ago
Hi @joy-ade

The reason this is happening is because there is an EMT second stage date set for the 22/07/21 and therefore the system requires the first EMT to be completed.

This was included on the development plan:

'When creating a EM tie-breaker the start and end dates for the test should default to the Equal Merit Second Phase start and end dates for the exercise'.
Would you like us to ignore the second stage and allow the end date to be set afterwards?

[KateMJAC]

@joy-ade, yesterday I outlined to Jeremy that there may be an outlier where a candidate needs to sit the test at a different date, after the intial test.

[JeremykJAC]

@KateMJAC We will remove the constraint that stops the tie breaker end date being forced to be before the second stage date. If this is ok, then we will do this first thing and hopefully we can get this ticket moving again :)

[HalcyonJAC]

I have done that now. Darrel.