Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1017 Mop up test won't start if the test is open before candidates added #1321

Merged
merged 1 commit into from
May 28, 2021

Conversation

lloback
Copy link
Contributor

@lloback lloback commented May 10, 2021

What's included?

Disabled OPEN TEST button if there is no candidates on the test

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

  1. Create a MOP UP test
  2. GO to the Qualifying test detail page and verify that the OPEN TEST button is disabled
  3. Go to the original test where the mopup was created from, select a user and transfer it to the new mopup
  4. Return to the MOPUP qualifying test detail page and check that the OPEN TEST button is enabled allowing the user to OPEN the test for users.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

image
image
image


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

…e added

Disabled OPEN TEST button if there is no candidates on the test
@lloback lloback requested review from a team as code owners May 10, 2021 16:31
@github-actions
Copy link

github-actions bot commented May 10, 2021

Visit the preview URL for this PR (updated for commit 573446f):

https://jac-admin-develop--pr1321-bugfix-1017-disable-sikhc00x.web.app

(expires Fri, 18 Jun 2021 15:26:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested and works as described

Copy link
Contributor

@mbrookeswebdev mbrookeswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joy-ade
Copy link

joy-ade commented May 12, 2021

@lloback I followed the step outlined to test. After creating the qualifying test, l couldn't initialise the test. Can you have a look at the code pls.

Copy link
Contributor

@tomlovesgithub tomlovesgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@tomlovesgithub tomlovesgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😗👌
perfect

@lloback
Copy link
Contributor Author

lloback commented May 13, 2021

@lloback I followed the step outlined to test. After creating the qualifying test, l couldn't initialise the test. Can you have a look at the code pls.

@joy-ade if there is an error that is not related to this PR you should raise a ticket for it, and we can take a look into it. There was no change on this code to the actual creation or initializing a Mopup. The code here is only related to the visibility / disability of the button.

@joy-ade
Copy link

joy-ade commented May 14, 2021

@lloback I followed the step outlined to test. After creating the qualifying test, l couldn't initialise the test. Can you have a look at the code pls.

@joy-ade if there is an error that is not related to this PR you should raise a ticket for it, and we can take a look into it. There was no change on this code to the actual creation or initializing a Mopup. The code here is only related to the visibility / disability of the button.

@lloback I have just tested this and its works perfectly. @KateMJAC will send it out to UTG, when she is ready.

@KateMJAC
Copy link

@lloback @joy-ade this has been sent to the UTG today. I will comment when I receive feedback.

Copy link

@KateMJAC KateMJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked for me. This has been sent to the UTG. Will approve when response is received.

@warrensearle warrensearle temporarily deployed to develop May 19, 2021 15:21 Inactive
Copy link

@joy-ade joy-ade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve by product team and UTG

@lloback lloback merged commit 0700c90 into main May 28, 2021
@lloback lloback deleted the bugfix/1017-disable-mop-up-open branch May 28, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants