-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1017 Mop up test won't start if the test is open before candidates added #1321
Conversation
…e added Disabled OPEN TEST button if there is no candidates on the test
Visit the preview URL for this PR (updated for commit 573446f): https://jac-admin-develop--pr1321-bugfix-1017-disable-sikhc00x.web.app (expires Fri, 18 Jun 2021 15:26:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Tested and works as described
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@lloback I followed the step outlined to test. After creating the qualifying test, l couldn't initialise the test. Can you have a look at the code pls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😗👌
perfect
@joy-ade if there is an error that is not related to this PR you should raise a ticket for it, and we can take a look into it. There was no change on this code to the actual creation or initializing a Mopup. The code here is only related to the visibility / disability of the button. |
@lloback I have just tested this and its works perfectly. @KateMJAC will send it out to UTG, when she is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and worked for me. This has been sent to the UTG. Will approve when response is received.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve by product team and UTG
What's included?
Disabled OPEN TEST button if there is no candidates on the test
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING