updating packages #1336
Merged
updating packages #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 7521827): https://jac-admin-develop--pr1336-security-1303-npm-au-enfsvcu8.web.app (expires Sun, 20 Jun 2021 15:21:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
HalcyonJAC
requested review from
tomlovesgithub,
warrensearle,
lloback and
mbrookeswebdev
mbrookeswebdev
approved these changes
May 21, 2021
HalcyonJAC
force-pushed
the
security/1303-npm-audit
branch
from
09d0213 to
7521827
Compare
warrensearle
approved these changes
May 25, 2021
|
Hey @joy-ade just to confirm the acceptance test for this ticket is to check and see if Admin is still working (using the preview url). No visual changes have been made. |
|
@warrensearle I have tested the Admin and its works. PR has been approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have resolved some security vulnerabilities by doing the following:
firebase-toolspackage as had a vulnerability in it and the package wasn't being used anywhere. Note: If we need it in future add the latest (secure) version.sass-loaderto v10 (which is the latest version of sass-loader that is compatible with Vue CLI v4). The application now compiles faster :)I also resolved some minor compilation warnings coming from the linter
Note: The majority of the vulnarabilities left are moderate and caused by an outdated version of
postcssbut upgrading this would require many other packages to be upgraded too.PREVIEW:DEVELOP