Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Modal wont cancel, PQE blank fields bug, char info shows 'no info...' rather than no #1537

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

tomlovesgithub
Copy link
Contributor

@tomlovesgithub tomlovesgithub commented Dec 22, 2021

issues addressed

  • Modal wont cancel
  • PQE blank fields bug
  • char info shows 'no info...' rather than no
  • Inputing custom othertask overwrites tasks
  • a few places relied on obj.change which was meant as a check for the existence of the value, currently doesnt accommodate false values

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@tomlovesgithub tomlovesgithub requested review from a team as code owners December 22, 2021 14:15
@tomlovesgithub tomlovesgithub temporarily deployed to develop December 22, 2021 14:20 Inactive
@tomlovesgithub tomlovesgithub temporarily deployed to develop December 22, 2021 14:20 Inactive
@github-actions
Copy link

github-actions bot commented Dec 22, 2021

Visit the preview URL for this PR (updated for commit e34006a):

https://jac-admin-develop--pr1537-260-tidy-up-2gm71wlk.web.app

(expires Sat, 22 Jan 2022 17:51:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@tomlovesgithub tomlovesgithub temporarily deployed to develop December 22, 2021 15:38 Inactive
@tomlovesgithub tomlovesgithub temporarily deployed to develop December 22, 2021 15:38 Inactive
@tomlovesgithub tomlovesgithub temporarily deployed to production December 22, 2021 16:41 Inactive
@tomlovesgithub tomlovesgithub temporarily deployed to develop December 22, 2021 16:48 Inactive
@tomlovesgithub tomlovesgithub temporarily deployed to develop December 22, 2021 16:49 Inactive
@tomlovesgithub tomlovesgithub temporarily deployed to develop December 23, 2021 17:48 Inactive
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @tomlovesgithub 👍

@tomlovesgithub tomlovesgithub merged commit 2d0d05d into main Dec 23, 2021
@tomlovesgithub tomlovesgithub deleted the 260-tidy-up branch December 23, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants