Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#260 Application view improvements #1539

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Conversation

warrensearle
Copy link
Member

@warrensearle warrensearle commented Dec 29, 2021

What's included?

Fixes issues with application view

The following issues have been addressed:

  • Character Information. Only show details when candidate answered Yes
  • Character Information. Other character issues. Show Yes|No rather than code
  • Gaps in Employment. Show 'No answers provided' when data is empty
  • Gaps in Employment. Show Details instead of Organisation and Job Title

Who should test?

✅ Product owner

How to test?

Check that the preview url (below) solves the issues addressed by this PR
Compare with live/production

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Related permissions

  • No permission changes required

PREVIEW:PRODUCTION
can be OFF, DEVELOP or STAGING

- Character Information. Only show details when candidate answered Yes
- Character Information. Other character issues. Show Yes|No
- Gaps in Employment. Show 'No answers provided' when data is empty
- Gaps in Employment. Show Details instead of Organisation and Job Title
@warrensearle warrensearle requested review from a team as code owners December 29, 2021 17:19
@warrensearle warrensearle temporarily deployed to production December 29, 2021 17:20 Inactive
@warrensearle warrensearle temporarily deployed to production December 29, 2021 17:21 Inactive
@github-actions
Copy link

github-actions bot commented Dec 29, 2021

Visit the preview URL for this PR (updated for commit ea228cf):

https://jac-apply-admin-production--pr1539-feature-260-applica-rbpi80fl.web.app

(expires Fri, 28 Jan 2022 17:23:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link

@joy-ade joy-ade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by product team

@joy-ade joy-ade merged commit 2febe95 into main Dec 30, 2021
@joy-ade joy-ade deleted the feature/260-application-view-fixes branch December 30, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants