Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tables display of candidates within panel pack #1550

Merged
merged 4 commits into from
Jan 17, 2022

Conversation

tomlovesgithub
Copy link
Contributor

What's included?

panel pack needed Table Component to be updated to work with latest jac-kit version

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

  • Go to an exercise ready for panel pack creation
  • Create or view a panel
  • Add a candidate if needed
  • ensure candidate table appears

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

image


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@tomlovesgithub tomlovesgithub requested review from a team as code owners January 17, 2022 13:09
@tomlovesgithub tomlovesgithub temporarily deployed to develop January 17, 2022 13:11 Inactive
@github-actions
Copy link

github-actions bot commented Jan 17, 2022

Visit the preview URL for this PR (updated for commit 3dbceb7):

https://jac-admin-develop--pr1550-panel-pack-table-0v68vqgr.web.app

(expires Wed, 16 Feb 2022 13:36:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@tomlovesgithub tomlovesgithub temporarily deployed to develop January 17, 2022 13:33 Inactive
Copy link

@andrew-isaac andrew-isaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - all working. I used this url - https://jac-admin-develop--pr1550-panel-pack-table-0v68vqgr.web.app/exercise/5r40soW2fFmv50UEmkxP/tasks/sift/view/MvbiT44VzJYHXgmJS6X4

Added a candidate to the exercise, created panel members and then assigned the candidate to the panel, which pulled through fine and showed in the table as expected

Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tomlovesgithub tomlovesgithub merged commit 4f1277f into main Jan 17, 2022
@tomlovesgithub tomlovesgithub deleted the panel-pack-table branch January 17, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants