update jac Kit for Qt DL button #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrensearle
approved these changes
Jul 1, 2022
HalcyonJAC
approved these changes
Jul 1, 2022
andrew-isaac
approved these changes
Jul 12, 2022
tomlovesgithub
force-pushed
the
update-jac-kit-qt-response-download
branch
from
5e8e97a to
84e5fb5
Compare
|
Visit the preview URL for this PR (updated for commit b1154d8): https://jac-admin-develop--pr1665-update-jac-kit-qt-re-1kblkj8d.web.app (expires Sun, 14 Aug 2022 16:27:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
JAC-kit update amends the styling which was causing an issue which made the buttons un-clickable.
This issue was raised specifically around QT response downloads.
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING