#1693 Bugfix: handover report table is stuck in loading state #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 1ca54b1): https://jac-admin-develop--pr1699-bugfix-1693-handover-0tsdl4md.web.app (expires Fri, 26 Aug 2022 16:08:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
andrew-isaac
approved these changes
Jul 27, 2022
andrew-isaac
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Fix the table loading state on handover report.
Note: when Handover.vue is created, it will bind to firestore document and get the report data before Table component is rendered. And when Table component is mounted, it will set loading state to true. That's why the table already got data but the loading state is still showing.
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
Demo:
1693.Bugfix.handover.report.table.is.stuck.in.loading.state.mov
Related permissions
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING