Hotfix: #1705 Panel name link not working #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalcyonJAC
changed the title
|
Visit the preview URL for this PR (updated for commit 26ca97a): https://jac-admin-develop--pr1706-hotfix-1705-panel-na-hj35hc48.web.app (expires Fri, 02 Sep 2022 16:15:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
tomlovesgithub
approved these changes
Aug 3, 2022
andrew-isaac
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
When click the panel name link it just loops back around to the same screen. The current solution is to remove the
target="_blank"on the anchor link.Note: when
PanelsViewcomponent is created, it will check the selected panel state and redirect to the previous page if it's empty. That's why the link will loop back when we open it in a new tab.Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Go to Task
SiftorSelection daypage and check if panel name link works.Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
Demo:
1705.panel.name.link.not.working.mov
Related permissions
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING