Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotesList local-data #1737

Merged
merged 1 commit into from
Oct 10, 2022
Merged

NotesList local-data #1737

merged 1 commit into from
Oct 10, 2022

Conversation

tomlovesgithub
Copy link
Contributor

What's included?

Small change here, only place i found the loading issue with tables.

Who should test?

✅ Product owner
✅ Developers

How to test?

  • Find candidate with notes
  • Open notes tab
  • There should be no loading issue

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@tomlovesgithub tomlovesgithub temporarily deployed to develop September 16, 2022 16:03 Inactive
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 038d750):

https://jac-admin-develop--pr1737-local-data-on-tables-u7l7ql6w.web.app

(expires Sun, 16 Oct 2022 16:06:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@tomlovesgithub tomlovesgithub marked this pull request as ready for review September 20, 2022 16:09
@tomlovesgithub tomlovesgithub requested review from a team as code owners September 20, 2022 16:09
Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lloback
Copy link
Contributor

lloback commented Oct 6, 2022

@lloback lloback merged commit ad5675b into main Oct 10, 2022
@lloback lloback deleted the local-data-on-tables branch October 10, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants