Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1714 ACRO Template on Agency Reports #1748

Merged
merged 5 commits into from
Nov 2, 2022

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Oct 6, 2022

What's included?

Export ACRO report. Here is the ACRO form.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

  1. Go to Agency Reports of an exercise and click "Export data".
  2. Check if data is populated.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Demo:

admin.1714.ACRO.Template.on.Agency.Reports_1.mov

Related permissions

  • No permission changes required

PREVIEW:DEVELOP

@HalcyonJAC HalcyonJAC self-assigned this Oct 6, 2022
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 6, 2022 15:37 Inactive
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Visit the preview URL for this PR (updated for commit d513fde):

https://jac-admin-develop--pr1748-feature-1714-acro-te-6x33nnt8.web.app

(expires Thu, 10 Nov 2022 10:10:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@HalcyonJAC HalcyonJAC temporarily deployed to develop October 7, 2022 16:13 Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 7, 2022 16:23 Inactive
@HalcyonJAC HalcyonJAC marked this pull request as ready for review October 7, 2022 16:24
@HalcyonJAC HalcyonJAC requested review from a team as code owners October 7, 2022 16:24
@HalcyonJAC HalcyonJAC requested review from andrew-isaac, tomlovesgithub, lloback and warrensearle and removed request for lloback October 7, 2022 16:24
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 7, 2022 16:26 Inactive
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HalcyonJAC when we reviewed and estimated this task we agreed to keep things simple and just get the columns in the existing download to match those in the acro template. That's it. Simples!

@HalcyonJAC HalcyonJAC temporarily deployed to develop October 11, 2022 08:31 Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 11, 2022 10:01 Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 11, 2022 10:07 Inactive
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you 👍

@HalcyonJAC HalcyonJAC merged commit 4e0203f into main Nov 2, 2022
@HalcyonJAC HalcyonJAC deleted the feature/1714-acro-template-on-agency-reports branch November 2, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants