Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1770 Admin Amending Email Addresses for Candidates #1771

Merged

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Oct 27, 2022

What's included?

Allow a user to access Candidates - Actions and change an email address.

The right to do this should then be added to these User Roles:

  • Operations Team Member
  • Operations Senior Manager
  • Digital Super User

Note: this changes will remove hard coded permission control in "Candidates - Actions" page.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

  1. Go to a candidate page.
  2. Check if the current user which the user role is one of above roles can amend the candidate's email address.

Risk - how likely is this to impact other areas?

🟠 Medium risk - this does change code that is shared with other areas

Additional context

User role: Operations Senior Manager

#1770 Admin Amending Email Addresses for Candidates_2

User role: Other JAC Staff

#1770 Admin Amending Email Addresses for Candidates_1

Related permissions

  • Permissions have been added / updated. Details: canUpdateCandidates

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@HalcyonJAC HalcyonJAC self-assigned this Oct 27, 2022
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 27, 2022 09:14 Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 27, 2022 09:16 Inactive
@github-actions
Copy link

github-actions bot commented Oct 27, 2022

Visit the preview URL for this PR (updated for commit 9ebec45):

https://jac-admin-develop--pr1771-feature-1770-admin-a-o0hwego7.web.app

(expires Sat, 26 Nov 2022 09:18:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@HalcyonJAC HalcyonJAC marked this pull request as ready for review October 27, 2022 09:20
@HalcyonJAC HalcyonJAC requested review from a team as code owners October 27, 2022 09:20
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good to me 👍

Copy link
Contributor

@tomlovesgithub tomlovesgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@HalcyonJAC HalcyonJAC merged commit c217a3f into main Nov 3, 2022
@HalcyonJAC HalcyonJAC deleted the feature/1770-admin-amending-email-addresses-for-candidates branch November 3, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants