Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1719 Candidate flagging #1805

Merged
merged 25 commits into from
Feb 1, 2023
Merged

#1719 Candidate flagging #1805

merged 25 commits into from
Feb 1, 2023

Conversation

drieJAC
Copy link
Contributor

@drieJAC drieJAC commented Dec 1, 2022

What's included?

Added a flag to indicate that particular candidates on the system need to be handled sensitively.
Added a permission to determine who can see the button to flag/un-flag a candidate as needing to be handled sensitively.
An asterisk will appear next to their name on certain pages and an email is sent to the senior leadership team when they apply for a position.
Note that the candidates flagged/marked are usually involved with proceeding against the JAC and the management of their application needs to be handed sensitively. Having this will ensure a consistent approach and that any sensitive issues are dealt with correctly.

The email addresses of users who need to be notified when a candidate is flagged should be added to the firestore config. An array of email addresses can be added at: settings.services.emails.CandidateFlagging

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Flagging / Un-flagging a candidate

Please log in as a user with the 'Can flag candidates' permission - e.g. seniorleader@judicialappointments.digital

To flag/unflag a candidate go to the Candidate page and select the Notes tab. A flag/unflag button is displayed on the right hand side. This button should toggle between the flag and unflag states each time it is clicked.

When the user is flagged an email should be sent out to the senior leadership team. This email should only get sent once, ie repeat activation of the flag should not result in subsequent emails being sent.

Please log in as a user without the 'Can flag candidates' permission - e.g. jacstaff@judicialappointments.digital
Check that the Flag / Un-flag functionality is not present.

Identifying flagged candidates

The flagged candidates should have an asterisk on the following pages for all users:

  • Candidates list (asterisk appears next to the candidate's name)
  • Candidate page (asterisk appears next to the candidate's name)
  • Application page (asterisk appears next to the application's name)

On the Candidates list you can press the Show Filters button to display a checkbox allowing you to filter by 'flagged candidates only'. When this filter is activated only the flagged candidates should display in the list.

Additional Fix
In the Candidate page the 'edit' button should now only be displayed when the Details tab is active. Previously the edit button was showing on every tab.

Permissions

A new permission has been added. The user needs to have the 'Can flag candidates' permission checked in order to be able to flag/unflag candidates.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@warrensearle warrensearle changed the base branch from main to feature/794-emulator-suite December 7, 2022 11:12
@warrensearle warrensearle changed the title Feature/1719 candidate flagging #1719 Candidate flagging Dec 7, 2022
@warrensearle warrensearle temporarily deployed to develop December 7, 2022 12:39 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Visit the preview URL for this PR (updated for commit 2699466):

https://jac-admin-develop--pr1805-feature-1719-candida-gysd8jmt.web.app

(expires Fri, 17 Feb 2023 12:34:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@drieJAC drieJAC temporarily deployed to develop December 7, 2022 13:12 — with GitHub Actions Inactive
@drieJAC drieJAC temporarily deployed to develop December 7, 2022 13:14 — with GitHub Actions Inactive
@warrensearle warrensearle temporarily deployed to develop December 7, 2022 13:24 — with GitHub Actions Inactive
@warrensearle warrensearle temporarily deployed to develop December 7, 2022 16:24 — with GitHub Actions Inactive
@warrensearle warrensearle temporarily deployed to develop December 7, 2022 16:26 — with GitHub Actions Inactive
@warrensearle
Copy link
Member

Failed User Testing for the following reasons:

  • Filtering the candidates list not working (wheel of death)
  • Flag not showing on applications list (acceptable as future work)

Also we have the following questions:

  • Should staff be required to enter a Note (or should an automated note be added)?

@drieJAC drieJAC temporarily deployed to develop January 9, 2023 15:38 — with GitHub Actions Inactive
@warrensearle warrensearle marked this pull request as ready for review January 11, 2023 11:12
@warrensearle warrensearle requested review from a team as code owners January 11, 2023 11:12
@andrew-isaac
Copy link

Admin stated they couldn't see the option to flag candidates. I have not tested the pull request myself to comment but adding the feedback in.

@drieJAC drieJAC temporarily deployed to develop January 12, 2023 10:40 — with GitHub Actions Inactive
@warrensearle warrensearle temporarily deployed to develop January 18, 2023 11:58 — with GitHub Actions Inactive
@warrensearle warrensearle temporarily deployed to develop January 18, 2023 12:31 — with GitHub Actions Inactive
@warrensearle
Copy link
Member

Recent updates to permissions and demo users mean this should be easier to test now. 🤞
Instructions updated.

Copy link

@andrew-isaac andrew-isaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly for me! Having the log ins for the different accounts makes it really easy :)

Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great to me 👍

Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@warrensearle warrensearle merged commit f16e908 into main Feb 1, 2023
@warrensearle warrensearle deleted the feature/1719-candidate-flagging branch February 1, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants