Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1834 Bugfix: show no qualifications after amend #1835

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Dec 16, 2022

What's included?

When an admin user amends a candidate's qualifications on the admin site, it will not show correctly on the apply site due to the data structure changing from array to object in Firestore. This PR will fix this problem.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Scenario 1

  1. [admin] Find an application and add new qualifications
  2. [apply] Go to the qualification section and check if the information shows correctly.

Scenario 2

  1. [apply] Go to the qualification section and fill in some qualifications
  2. [admin] Go to the application and check if the information shows correctly.
  3. [admin] Amend the qualifications (e.g. location, date)
  4. [apply] Go to the qualification section and check if the information has been amended correctly.

Risk - how likely is this to impact other areas?

🟠 Medium risk - this does change code that is shared with other areas

Additional context

  1. Add new qualifications
Screen.Recording.2022-12-16.at.11.53.11.mov
  1. Amend current qualifications
Screen.Recording.2022-12-16.at.11.55.08.mov

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required

PREVIEW:DEVELOP

@HalcyonJAC HalcyonJAC self-assigned this Dec 16, 2022
@HalcyonJAC HalcyonJAC temporarily deployed to develop December 16, 2022 11:19 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Dec 16, 2022

Visit the preview URL for this PR (updated for commit 3b2f6b1):

https://jac-admin-develop--pr1835-bugfix-1834-show-no-1y0leicq.web.app

(expires Sun, 15 Jan 2023 12:09:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@HalcyonJAC HalcyonJAC temporarily deployed to develop December 16, 2022 12:07 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC marked this pull request as ready for review December 16, 2022 13:02
@HalcyonJAC HalcyonJAC requested review from a team as code owners December 16, 2022 13:02
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HalcyonJAC HalcyonJAC merged commit 929b870 into main Dec 20, 2022
@HalcyonJAC HalcyonJAC deleted the bugfix/1834-show-no-qualifications-after-amend branch December 20, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants