Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: previous and next buttons not show in default pagination #1851

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Jan 18, 2023

What's included?

Fix the Previous and Next buttons do not show when using the default pagination.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

[Default pagination]

  1. Go to the exercises page (with over 50 exercises) and check if Previous and Next buttons work properly.
  2. Go to the selected list under Stages section (with over 50 applications) and check if Previous and Next buttons work properly.

[Letter pagination]

  1. Go to Applications tab of an exercise and check if there are no Previous and Next buttons.

Risk - how likely is this to impact other areas?

🟠 Medium risk - this does change code that is shared with other areas

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required

PREVIEW:DEVELOP

@HalcyonJAC HalcyonJAC self-assigned this Jan 18, 2023
@HalcyonJAC HalcyonJAC temporarily deployed to develop January 18, 2023 12:54 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 18, 2023

Visit the preview URL for this PR (updated for commit 9e47a06):

https://jac-admin-develop--pr1851-bugfix-prev-next-not-dos7mht7.web.app

(expires Fri, 17 Feb 2023 13:02:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@HalcyonJAC HalcyonJAC temporarily deployed to develop January 18, 2023 13:00 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC marked this pull request as ready for review January 18, 2023 13:02
@HalcyonJAC HalcyonJAC requested review from a team as code owners January 18, 2023 13:02
@HalcyonJAC HalcyonJAC merged commit 7a58037 into main Jan 18, 2023
@HalcyonJAC HalcyonJAC deleted the bugfix/prev-next-not-show-in-default-pagination branch January 18, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants