Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1840/remove HMRC check #1881

Merged
merged 6 commits into from
Feb 21, 2023
Merged

1840/remove HMRC check #1881

merged 6 commits into from
Feb 21, 2023

Conversation

tomlovesgithub
Copy link
Contributor

What's included?

  • Removed the 'Will HMRC checks be required?' question as these are now asked of all candidates.
  • Ensure the Character Checks page loads directly as opposed to loading the above question
  • Remove the HRMC check shown in the character check overview list and the change button.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Find a live exercise with character checks and seek to locate the HMRC check options.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work
🟠 Medium risk - this does change code that is shared with other areas
🔴 High risk - this includes a lot of changes to shared code

Additional context

Before
image
image
After
image


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@tomlovesgithub tomlovesgithub requested review from a team as code owners February 6, 2023 13:57
@tomlovesgithub tomlovesgithub temporarily deployed to develop February 6, 2023 13:59 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Visit the preview URL for this PR (updated for commit 22bae93):

https://jac-admin-develop--pr1881-1840-remove-hmrc-che-8178c11a.web.app

(expires Thu, 23 Mar 2023 10:35:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomlovesgithub tomlovesgithub temporarily deployed to develop February 8, 2023 20:04 — with GitHub Actions Inactive
@warrensearle
Copy link
Member

@warrensearle
Copy link
Member

@tomlovesgithub has addressed the problems so this is ready for user testing again

@warrensearle warrensearle temporarily deployed to develop February 21, 2023 10:31 — with GitHub Actions Inactive
@tomlovesgithub tomlovesgithub merged commit 5815ec3 into main Feb 21, 2023
@tomlovesgithub tomlovesgithub deleted the 1840/remove-hmrc-check branch February 21, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants