Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1772/phone number issues #1887

Merged
merged 4 commits into from
Feb 21, 2023
Merged

1772/phone number issues #1887

merged 4 commits into from
Feb 21, 2023

Conversation

tomlovesgithub
Copy link
Contributor

@tomlovesgithub tomlovesgithub commented Feb 9, 2023

What's included?

  • EditableField for telephone on personal details which enables tel validation

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

  • visit application under exercise
  • Find phone number input on personal details edit
  • input phone number with spaces

Risk - how likely is this to impact other areas?

🟠 Medium risk - this does change code that is shared with other areas


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@tomlovesgithub tomlovesgithub temporarily deployed to develop February 9, 2023 17:46 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Visit the preview URL for this PR (updated for commit 08a97da):

https://jac-admin-develop--pr1887-1772-phone-number-is-ckg2c6r1.web.app

(expires Sun, 12 Mar 2023 15:38:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@tomlovesgithub tomlovesgithub temporarily deployed to develop February 10, 2023 15:29 — with GitHub Actions Inactive
@tomlovesgithub tomlovesgithub marked this pull request as ready for review February 10, 2023 15:34
@tomlovesgithub tomlovesgithub requested review from a team as code owners February 10, 2023 15:34
@tomlovesgithub tomlovesgithub temporarily deployed to develop February 10, 2023 15:36 — with GitHub Actions Inactive
@tomlovesgithub tomlovesgithub merged commit 8cbe283 into main Feb 21, 2023
@tomlovesgithub tomlovesgithub deleted the 1772/phone-number-issues branch February 21, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants