-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1901 Reasonable Adjustments - Additions to ticket 1842 #1905
#1901 Reasonable Adjustments - Additions to ticket 1842 #1905
Conversation
Visit the preview URL for this PR (updated for commit 7b88297): https://jac-admin-develop--pr1905-feature-1901-reasona-4yega82f.web.app (expires Fri, 31 Mar 2023 10:52:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
Hey @andrew-isaac can you double check one of the requirements in this ticket please: is this really meant to add 'Scenario Test' as an option in the 'Status' dropdown? Wouldn't adding 'Scenario Test' as an option under 'Where the reasonable adjustment was given' make more sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, just a question about the requirement (see my earlier comment)
@warrensearle thank you for spotting my stupid mistake! The ST bit should be under where the adjustment was given - the other drop down :) Ryan can you amend it please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@warrensearle thank you for spotting my stupid mistake! The ST bit should be under where the adjustment was given - the other drop down :)
Ryan can you amend it please? Sorry it is my fault!
What's included?
Closes #1901
Scenario Test
to theWhere the reasonable adjustments was given
drop-down.Add another
to add another status and reason.Where the reasonable adjustments was given
for admin to record any extra time or % of the time given.Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Go to Reasonable Adjustments Report and check if the above items work.
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
Demo:
Screen.Recording.2023-02-23.at.12.42.46.mov
Related permissions
Have permissions been considered for this functionality?
PREVIEW:DEVELOP