Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1901 Reasonable Adjustments - Additions to ticket 1842 #1905

Merged
merged 7 commits into from
Mar 8, 2023

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Feb 20, 2023

What's included?

Closes #1901

  • Add Scenario Test to the Where the reasonable adjustments was given drop-down.
  • Add a button Add another to add another status and reason.
  • Add a text box underneath Where the reasonable adjustments was given for admin to record any extra time or % of the time given.
  • Export the most recent Reasonable adjustment for the candidate and show it in the spreadsheet.
  • Show status, reason, and note in the RA history.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Go to Reasonable Adjustments Report and check if the above items work.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Demo:

Screen.Recording.2023-02-23.at.12.42.46.mov

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required

PREVIEW:DEVELOP

@HalcyonJAC HalcyonJAC self-assigned this Feb 20, 2023
@HalcyonJAC HalcyonJAC temporarily deployed to develop February 20, 2023 12:30 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 20, 2023

Visit the preview URL for this PR (updated for commit 7b88297):

https://jac-admin-develop--pr1905-feature-1901-reasona-4yega82f.web.app

(expires Fri, 31 Mar 2023 10:52:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@HalcyonJAC HalcyonJAC temporarily deployed to develop February 20, 2023 12:54 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop February 21, 2023 12:02 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop February 22, 2023 13:02 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop February 23, 2023 12:37 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop February 23, 2023 12:43 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop February 23, 2023 12:46 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop February 24, 2023 09:22 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC marked this pull request as ready for review February 24, 2023 10:13
@HalcyonJAC HalcyonJAC requested review from a team as code owners February 24, 2023 10:13
@warrensearle
Copy link
Member

Hey @andrew-isaac can you double check one of the requirements in this ticket please: is this really meant to add 'Scenario Test' as an option in the 'Status' dropdown? Wouldn't adding 'Scenario Test' as an option under 'Where the reasonable adjustment was given' make more sense?

Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, just a question about the requirement (see my earlier comment)

@andrew-isaac
Copy link

@warrensearle thank you for spotting my stupid mistake! The ST bit should be under where the adjustment was given - the other drop down :)

Ryan can you amend it please?

Copy link

@andrew-isaac andrew-isaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@warrensearle thank you for spotting my stupid mistake! The ST bit should be under where the adjustment was given - the other drop down :)

Ryan can you amend it please? Sorry it is my fault!

@HalcyonJAC HalcyonJAC temporarily deployed to develop March 1, 2023 09:02 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC requested a review from andrew-isaac March 1, 2023 09:28
@HalcyonJAC HalcyonJAC temporarily deployed to develop March 1, 2023 09:32 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop March 1, 2023 10:48 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC merged commit e434ddb into main Mar 8, 2023
@HalcyonJAC HalcyonJAC deleted the feature/1901-reasonable-adjustments-additions branch March 8, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reasonable Adjustments - Additions to ticket 1842
4 participants