Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1911 Enable QTs to be set up while exercise is still open #1920

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

warrensearle
Copy link
Member

@warrensearle warrensearle commented Feb 27, 2023

What's included?

Enable QTs to be set up while an exercise is still open or processing applications has not yet started.

Closes #1911

Who should test?

✅ Product owner
✅ Developers

How to test?

Locate an exercise which is open, has some applications, will be running a QT and is not yet closed for applications.
Navigate to Tasks and select Critical Analysis or Situational Judgement test.

Before this change/fix
It was not possible to 'Continue' with the task and prepare the live QT
image.png

After this change/fix
The user must confirm key details of the task and can then 'Continue' with the task and prepare the live QT
image.png

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@warrensearle warrensearle temporarily deployed to develop February 27, 2023 16:24 — with GitHub Actions Inactive
@warrensearle warrensearle temporarily deployed to develop February 27, 2023 16:24 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 27, 2023

Visit the preview URL for this PR (updated for commit 81a6544):

https://jac-admin-develop--pr1920-feature-1911-new-tas-5hobm0z5.web.app

(expires Thu, 30 Mar 2023 10:30:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@warrensearle warrensearle marked this pull request as ready for review February 27, 2023 17:09
@warrensearle warrensearle requested review from a team as code owners February 27, 2023 17:09
@warrensearle warrensearle temporarily deployed to develop February 27, 2023 17:10 — with GitHub Actions Inactive
@warrensearle warrensearle changed the title #1911 Enable QTs to be set up whilst exercise is still open #1911 Enable QTs to be set up while exercise is still open Feb 28, 2023
@warrensearle warrensearle temporarily deployed to develop February 28, 2023 10:27 — with GitHub Actions Inactive
@warrensearle warrensearle temporarily deployed to develop February 28, 2023 10:27 — with GitHub Actions Inactive
Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great to me.

@warrensearle warrensearle merged commit 374c4bb into main Feb 28, 2023
@warrensearle warrensearle deleted the feature/1911-new-task branch February 28, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable QTs to be set up whilst exercise is still open
3 participants