Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include other qualfications #1937

Merged
merged 3 commits into from
Mar 30, 2023
Merged

include other qualfications #1937

merged 3 commits into from
Mar 30, 2023

Conversation

tomlovesgithub
Copy link
Contributor

What's included?

Custom 'Other' qualifications from admin were not pulling thru and showing on apply.
They were equally not showing upon admin edit of applications either.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

  • Using a legal exercise on admin with a custom "other" qualification
  • Edit an applications qualifications and ensure this custom qualification appears as an enterable option

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, notes etc.


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@tomlovesgithub tomlovesgithub temporarily deployed to develop March 21, 2023 12:53 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Mar 21, 2023

Visit the preview URL for this PR (updated for commit ab52cdf):

https://jac-admin-develop--pr1937-1842-other-qualifica-qhqyqs1u.web.app

(expires Sat, 29 Apr 2023 12:33:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomlovesgithub tomlovesgithub temporarily deployed to develop March 30, 2023 12:29 — with GitHub Actions Inactive
@tomlovesgithub tomlovesgithub merged commit 8570259 into main Mar 30, 2023
@tomlovesgithub tomlovesgithub deleted the 1842/other-qualifications branch March 30, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants