JAC-KIT#107 Use latest version of jac-kit which trims whitespace from inputs #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a9049f2): https://jac-admin-develop--pr1979-hotfix-upgrade-jac-k-qkyouq47.web.app (expires Fri, 02 Jun 2023 16:33:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
andrew-isaac
approved these changes
May 5, 2023
HalcyonJAC
approved these changes
May 9, 2023
tomlovesgithub
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Use latest version of jac-kit which trims whitespace from inputs.
Closes jac-uk/jac-kit#107
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Add whitespace at beginning or end of any text or textarea input field. When the data is re-displayed you should see no whitespace at the beginning nor end of the data. eg update the candidate first name with leading or trailing whitespace and ensure it doesnt appear when re-displayed.
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Related permissions
Have permissions been considered for this functionality?
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING