Remove NPM Audit Checks #2056
Merged
Remove NPM Audit Checks #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gh vulnerability errors.
|
Visit the preview URL for this PR (updated for commit 7b78d44): https://jac-admin-develop--pr2056-hotfix-remove-npm-au-wianxgw8.web.app (expires Wed, 09 Aug 2023 13:05:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
warrensearle
approved these changes
Jul 10, 2023
HalcyonJAC
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Urgently commented out 'npm audit --omti=dev' in github actions as blocking release whilst there are high vulnerability errors.
In future we will need a process for dealing with this.
See:
GHSA-h755-8qp9-cq85
Who should test?
✅ Product owner
✅ Developers
✅ UTG
Risk - how likely is this to impact other areas?
🔴 High risk - this includes a lot of changes to shared code
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING