Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2133 Additional application fields in custom report #2134

Merged

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Sep 12, 2023

What's included?

Closes #2133

Missing application fields:

Application Info

  • Place of birth
  • Current Address
  • Has lived at this address for more than 5 years
  • Previous Addresses
  • VAT registration number

Equality and Diversity

  • Agreed to share data
  • Professional background
  • Current legal role
  • Held fee-paid judicial role
  • Attended state or fee-paying school
  • Attended Oxbridge universities
  • First generation to go to university
  • Ethnic group
  • Sex
  • Gender is the same as sex assigned at birth
  • Sexual orientation
  • Disability
  • Disability details
  • Religion
  • Attended outreach events
  • Participated In judicial workshadowing Scheme
  • Participated in Pre-Application Judicial Education Programme

Part Time Working Preferences

  • Interested in part time?
  • Salaried part-time work (SPTW) - Details

Assessor

  • First Assessor Type
  • Second Assessor Type

Rename application fields:

  • Previously known name(s) -> Previous known name(s)

Note: This PR is related to digital-platform: Admin#2133 additional fields in custom report and digital-platform: Bugfix/date format in custom report.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Example exercise: https://jac-admin-develop--pr2134-feature-2133-additio-73dpe68h.web.app/exercise/6fqqfchNpqEEqILBonhL/reports/custom

  1. Go to "Custom Report".
  2. Select the fields above and check if they are displayed in the table correctly.
  3. Download custom report and check if the selected fields are in the file.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@HalcyonJAC HalcyonJAC self-assigned this Sep 12, 2023
@HalcyonJAC HalcyonJAC temporarily deployed to develop September 12, 2023 11:23 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 12, 2023

Visit the preview URL for this PR (updated for commit 101a2d2):

https://jac-admin-develop--pr2134-feature-2133-additio-73dpe68h.web.app

(expires Thu, 26 Oct 2023 12:13:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@HalcyonJAC HalcyonJAC temporarily deployed to develop September 12, 2023 11:26 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop September 13, 2023 10:57 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop September 13, 2023 12:46 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop September 14, 2023 08:12 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop September 14, 2023 09:17 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop September 14, 2023 09:24 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop September 14, 2023 09:30 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop September 14, 2023 09:56 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop September 14, 2023 10:09 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop September 14, 2023 10:10 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC marked this pull request as ready for review September 14, 2023 10:12
@HalcyonJAC HalcyonJAC requested review from a team as code owners September 14, 2023 10:12
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. As discussed this morning there are some more fields we could include - e.g. salaried part time working details

Copy link
Contributor

@tomlovesgithub tomlovesgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏌️‍♂️

@HalcyonJAC HalcyonJAC temporarily deployed to develop September 19, 2023 00:00 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop September 19, 2023 07:56 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop September 26, 2023 12:12 — with GitHub Actions Inactive
@HalcyonJAC
Copy link
Contributor Author

Update:

  1. The date format of the date of birth has been fixed.

@HalcyonJAC HalcyonJAC merged commit fbc5524 into main Oct 17, 2023
@HalcyonJAC HalcyonJAC deleted the feature/2133-additional-application-fields-in-custom-report branch October 17, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional application fields in custom report
4 participants