#2120 Exercise page alignment is breaking after on-screen error messages are displayed #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 0a03807): https://jac-admin-develop--pr2152-hotfix-hotfix-2120-m-6ctuhch9.web.app (expires Sat, 28 Oct 2023 13:42:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
warrensearle
approved these changes
Oct 5, 2023
HalcyonJAC
approved these changes
Oct 6, 2023
tomlovesgithub
approved these changes
Oct 6, 2023
drieJAC
deleted the
hotfix/hotfix/2120-misalignment-after-onscreen-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
This fix relies on the jac-kit v3.0.37.
The problem was that the scrollIntoView was somehow causing the page content to shift to the left. It's difficult to say exactly why.
The fix involved changing the element being scrolled into view.
Closes #2120
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
The page should scroll back up to display the error summary and the left side of the page should NOT have the display bug as shown in the image below.
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING