Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2121 Ensure the Candidate Page Accounts For Post 01/04/2023 Social Mobility Fields #2157

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

drieJAC
Copy link
Contributor

@drieJAC drieJAC commented Oct 2, 2023

What's included?

Using latest jac-kit which has added checks so that post 0104 answers are reflected in the candidate details page. Prioritising post 0104 answers over pre-0104 ones.

Closes #2121

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Ensure the candidate page shows post 01-04-2023 candidate questions.

Note the following:

Post 01-04-2023 questions are:

  • Attended state or fee-paying school between 11-16
  • Occupation of childhood earner
  • Parents attended university

Pre 01-04-2023 questions are:

  • Attended state or fee-paying school
  • Attended Oxbridge universities
  • First generation to go to university

Test 1 - Post 01-04-2023 questions apply

Test 2 - Pre 01-04-2023 questions apply

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

… are reflected in the candidate details page. Prioritising post 0104 answers over pre-0104 ones.
@drieJAC drieJAC temporarily deployed to develop October 2, 2023 02:31 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Visit the preview URL for this PR (updated for commit e6b3760):

https://jac-admin-develop--pr2157-featire-2121-candida-jc7dqfev.web.app

(expires Fri, 10 Nov 2023 15:19:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@drieJAC drieJAC temporarily deployed to develop October 2, 2023 02:40 — with GitHub Actions Inactive
@drieJAC drieJAC self-assigned this Oct 2, 2023
@drieJAC drieJAC temporarily deployed to develop October 2, 2023 02:42 — with GitHub Actions Inactive
@warrensearle warrensearle changed the title #2121 Ensure the Candidate Page Is Account For Post 01/04/2023 Social Mobility Fields #2121 Ensure the Candidate Page Accounts For Post 01/04/2023 Social Mobility Fields Oct 9, 2023
@warrensearle warrensearle temporarily deployed to develop October 9, 2023 20:59 — with GitHub Actions Inactive
Copy link
Contributor

@Franceswog Franceswog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 1 has all 3 questions however, question 3 (Parents did not attend university) appears different in the application form as ''Parents attended university''. While Test 2 has all 3 questions displayed correctly.
image

@drieJAC
Copy link
Contributor Author

drieJAC commented Oct 10, 2023

Ok I have added a fix so that the section now appears like this:

Screenshot 2023-10-10 at 15 08 14

@drieJAC drieJAC temporarily deployed to develop October 10, 2023 14:24 — with GitHub Actions Inactive
Copy link
Contributor

@Franceswog Franceswog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 1 and Test 2 has all the correct questions on the application form.

@drieJAC drieJAC temporarily deployed to develop October 11, 2023 13:47 — with GitHub Actions Inactive
@drieJAC drieJAC temporarily deployed to develop October 11, 2023 15:17 — with GitHub Actions Inactive
@drieJAC drieJAC merged commit 6e6250d into main Oct 26, 2023
9 checks passed
@drieJAC drieJAC deleted the featire/2121-candidate-reflects-post-0104-answers branch October 26, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure the Candidate Page Accounts For Post 01/04/2023 Social Mobility Fields
5 participants