Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2143 capture commissioner conflicts #2179

Merged
merged 11 commits into from
Nov 21, 2023

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Oct 18, 2023

What's included?

Closes #2143

Note: This PR is related to digital-platform: Feature/Export commissioner conflicts.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Example exercise: https://jac-admin-develop--pr2179-feature-2143-capture-f3nlqymg.web.app/exercise/ONqUjAzhDS7rjh6dFJLB/reports/commissioner-conflicts

  1. Go to "Commissioner Conflicts" report.
  2. Check if the details of the commissioner conflicts are shown in the table.
  3. Click "Export to Word" and check if the report is exported to Google Drive (https://drive.google.com/drive/u/0/folders/1RjUXKqkn1tJUvarj2mmvV6W1vvyAlk3v).

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Demo:

Screen.Recording.2023-10-20.at.15.41.37.mov

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@HalcyonJAC HalcyonJAC self-assigned this Oct 18, 2023
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 18, 2023 10:48 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Visit the preview URL for this PR (updated for commit 8520c59):

https://jac-admin-develop--pr2179-feature-2143-capture-f3nlqymg.web.app

(expires Thu, 23 Nov 2023 10:30:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@HalcyonJAC HalcyonJAC temporarily deployed to develop October 18, 2023 22:05 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 19, 2023 11:03 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 19, 2023 11:23 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 20, 2023 12:49 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 20, 2023 12:55 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 20, 2023 13:00 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 20, 2023 14:43 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC marked this pull request as ready for review October 20, 2023 14:59
@HalcyonJAC HalcyonJAC requested review from a team as code owners October 20, 2023 14:59
Copy link
Contributor

@Franceswog Franceswog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the report was exported to google drive .

Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not see any conflicts in the table. When I clicked the export button, it whirred and said 'Success' but no report was downloaded.

@HalcyonJAC HalcyonJAC temporarily deployed to develop October 22, 2023 18:41 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 22, 2023 21:46 — with GitHub Actions Inactive
@HalcyonJAC
Copy link
Contributor Author

I could not see any conflicts in the table. When I clicked the export button, it whirred and said 'Success' but no report was downloaded.

@nickaddy I have created some dummy data for testing. The report will be saved to Google Drive or you can download it from the UI.

@HalcyonJAC HalcyonJAC requested a review from nickaddy October 23, 2023 09:27
Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described: word documents downloads to local drive, all stated conflicts presented on separate rows in word document.

@HalcyonJAC HalcyonJAC temporarily deployed to develop October 24, 2023 10:16 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 24, 2023 10:19 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop October 24, 2023 10:29 — with GitHub Actions Inactive
@HalcyonJAC HalcyonJAC merged commit 780590c into main Nov 21, 2023
6 checks passed
@HalcyonJAC HalcyonJAC deleted the feature/2143-capture-commissioner-conflicts branch November 21, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capture commissioner conflicts
5 participants