-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2154 Configure working preferences questions #2207
Conversation
Visit the preview URL for this PR (updated for commit eb50696): https://jac-admin-develop--pr2207-feature-2154-d8s2h7zf.web.app (expires Wed, 31 Jul 2024 14:13:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
@warrensearle As keen as I am to see the back of this, I cannot see half of this functionality on the preview url - I was testing on this exercise. I couldn't see any options to:
|
@warrensearle there seems to be an issue with saving after editing a candidate's loc or juri preference; the button turns yellow but does not disappear and when you click Done, changed answers have not been saved. |
@warrensearle Interestingly, I just submitted a new application and I did not experience the issue above - I was able to edit and save all responses. |
@nickaddy please can you approve this PR, particularly if you agree with the above suggestion |
What's included?
Additional configuration options for working preferences questions, as follows:
Closes #2154
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
We decided to continue to support current functionality for existing exercises and have new exercises benefit from the new functionality.
There are therefore two areas to test:
1. There should not be any breaking changes for existing exercises
Either pick an existing exercise that is configured with the original working preferences OR use the main admin-develop url to create a new exercise and configure working preferences for it.
View the chosen/created exercise on the Preview URL and check that working preferences works as expected (as it does on admin-develop). For example you could have admin-develop and preview url running in separate windows and compare the functionality side by side.
You should be able to:
Note: you may like to create an application via apply-develop so you can test viewing and editing applications.
Please highlight any breaking changes.
2. New exercises should benefit from the new functionality and the new functionality satisfies user requirements
Using the Preview URL please create a new exercise and check that the new working preferences functionality is available.
In particular check that the following functionality works as expected and also that the terminology and instructions provided are sufficiently clear.
Note: when you have tested the above please test this PR on Apply so that you have an application with the latest preferences data.
Then back in Admin continue to test the following in Applications:
Risk - how likely is this to impact other areas?
🟠 Medium risk - this does change code that is shared with other areas
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING