-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2159 Disallow archiving until exercise unpublished from website #2215
#2159 Disallow archiving until exercise unpublished from website #2215
Conversation
Ensure both messages cannot be shown as an unpublished AND unarchived exercise was allowing both messages to display.
Visit the preview URL for this PR (updated for commit 6d43732): https://jac-admin-develop--pr2215-feature-2159-disallo-5vj3g8aa.web.app (expires Sun, 31 Dec 2023 10:40:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not working for me; I tried on the Test Assessments Vue 3 exercise. It is published, but when I try to archive it, I just receive the 'Are you sure?' message shown below:
Additionally, the message when you try to archive a published exercise should read: "This exercise must be unpublished before it can be archived" and the user should be prevented from archiving until it has been unpublished and removed from Apply.
@warrensearle I've checked with Matt and he is content with how Omar has set this up. However, I've just run through the process and I think that when a user attempts to Archive a Live Published exercise, they should receive a modal: "This exercise is Live on Apply; by clicking accept, you authorise the exercise to be removed from Apply and archived" rather than the standard "Are you sure?" standard message. Is this possible? |
@nickaddy of course, thank you. It will be done 👍 |
@warrensearle Thanks for sorting. I noticed that the message received when unarchiving needs to be changed as it currently relates to archiving: |
Hi @nickaddy good spot! That message has been updated now so we have: We are not done yet though as I spotted a few extra tasks:
|
Hey @nickaddy as agreed I've removed the bulk archive and bulk delete functionality and also disabled the Publish button for archived exercises. Have also fixed a bug with the layout. Please do review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy days! Thanks for mopping up those other issues alongside :-)
What's included?
Disallow archiving until exercise is unpublished from website.
Here I'm actually un-publishing at the same time as archiving!
Closes #2159
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
See video attached below:
Screen.Recording.2023-11-09.at.02.49.11.mov
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING