#2248 Use global commissioners not exercise-specific #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit c86d49c): https://jac-admin-develop--pr2250-feature-2248-global-dxqg1cmb.web.app (expires Wed, 17 Jan 2024 12:16:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
warrensearle
requested review from
Franceswog,
tomlovesgithub,
drieJAC and
HalcyonJAC
drieJAC
approved these changes
Dec 15, 2023
|
@warrensearle Am I testing that the new commissioners appear in the contacts dropdown in Admin? In that regard, I'm wondering if we could include the commissioners' names in the dropdown list in the format Surname, Forename sorted by surname to make them easier to find for the SETs? Maybe I'm overegging the pudding... |
nickaddy
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Modifications to commissioner conflicts to use global commissioners list rather than an exercise-specific copy.
Closes #2248
Who should test?
✅ Product owner
✅ Developers
How to test?
Check that commissioner conflicts feature works as expected.
Risk - how likely is this to impact other areas?
🟠 Medium risk - this does change code that is shared with other areas
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING