Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2229/ra report updates #2297

Merged
merged 27 commits into from
Mar 13, 2024
Merged

2229/ra report updates #2297

merged 27 commits into from
Mar 13, 2024

Conversation

tomlovesgithub
Copy link
Contributor

What's included?

Numerous changes to the RA report;

  • Display shows IA details for current exercise
  • On screen fields given clear labels
  • Additional drop down to allocate RA given as a %
  • Fixed search functionality
  • Candidate Email and Telephone number displayed next to name to contact
  • Facility to flag candidates as actioned and filter actioned candidates from the view

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Not ready for pass/fail testing.

Please advise testers to interact with the page and give feedback for improvements and changes to make the feature more useful

Risk - how likely is this to impact other areas?

🟠 Medium risk - this does change code that is shared with other areas

Closes #2229

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Jan 31, 2024

Visit the preview URL for this PR (updated for commit 3fa5e4c):

https://jac-admin-develop--pr2297-2229-ra-report-updat-6uq60jjt.web.app

(expires Sat, 30 Mar 2024 15:11:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@nickaddy
Copy link
Contributor

nickaddy commented Feb 6, 2024

@tomlovesgithub Responses from UT/meeting with Sean to be factored in to this ticket:

  • Replace View application text with candidate reference number (retain as link to their application)

image.png

  • Include Approval status, RA allocated and Describe RA given in export
  • Add Other in the RA allocated dropdown - this would cover circumstances where the RA is sthg other than time added

@nickaddy
Copy link
Contributor

nickaddy commented Feb 13, 2024

@tomlovesgithub Can you pls factor in these outputs from last week's UT/myself:

  • When you click the application hyperlink it takes you directly to the issues tab, it be more beneficial to go to the full information tab
  • Add labels to the dropdown filters - Status and RA Approval Status

image.png

  • Resolve the alignment at the top - is it possible to have the filters and the checkbox all on the same row?

@tomlovesgithub
Copy link
Contributor Author

image
@nickaddy Above issues have been resolved, worth noting that ideally we could implement the reverted change from a few weeks ago, meaning we are getting the most out of the table component.

Copy link
Contributor

@NormaJAC NormaJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@nickaddy
Copy link
Contributor

nickaddy commented Feb 23, 2024

Further feedback to implement:

  • Selecting an option from the Application Status dropdown causes another dropdown to appear, which is misaligned, and a Loading timer – the page then freezes as shown:

image.png

  • From a UI perspective, there should be more whitespace between the 3 dropdown menus at the top of the page; they are currently all squashed together with the result that they’re not easy to read

  • Candidate names in column A of download should be in format Lastname, Firstname

  • Approval status, RA allocated and RA description data is not appearing in the download

  • RA applies to column needs to be included in download

@KoWeiJAC
Copy link
Contributor

KoWeiJAC commented Mar 4, 2024

@nickaddy
Could you help me to confirm the RA report format when having multiple RA items ? Thanks
Is following format ok?
Screenshot 2024-03-04 at 10 27 29

Screenshot 2024-03-04 at 10 44 05

Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HalcyonJAC HalcyonJAC merged commit c05e1b1 into main Mar 13, 2024
6 checks passed
@HalcyonJAC HalcyonJAC deleted the 2229/ra-report-updates branch March 13, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to Reasonable Adjustments
6 participants